Glasgow | 26-ITP-May | Chan Yat Long | Sprint 2 | Wireframe#1239
Open
Motorcycle-lab wants to merge 14 commits into
Open
Glasgow | 26-ITP-May | Chan Yat Long | Sprint 2 | Wireframe#1239Motorcycle-lab wants to merge 14 commits into
Motorcycle-lab wants to merge 14 commits into
Conversation
Added new content and structure to the wireframe HTML.
Removed duplicate header section and added stylesheet link.
Removed starter comments and added styles for page header and article layout.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
changed the title
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Motorcycle-lab
added
NotCoursework
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
changed the title
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Motorcycle-lab
added
📅 Sprint 2
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Motorcycle-lab
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
LonMcGregor
added
the
Needs Review
cjyuan
added
Review in progress
Contributor
|
Your One way to delete the latest 5 commits is to run these commands on terminal in VSCode: Note: Please backup all your files (in all branches) before you executed these command. You may lose your files if you are not careful. |
cjyuan
reviewed
May 16, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you improve the Lighthouse score from 98 to 100?
Comment on lines
+3
to
+12
| <head> | ||
| <title>Wireframe Guide</title> | ||
| <link rel="stylesheet" href="style.css"> | ||
| </head> | ||
|
|
||
|
|
||
| <body><header class="page-header"> | ||
|
|
||
| <h1> Wireframe </h1> | ||
| <p class="short-description">Your guide to version control and design.</p> |
Contributor
There was a problem hiding this comment.
Indentation is off.
Please follow this guide to
enable "Format on Save" in VS Code or use VS Code's "Format Document" feature to keep your code consistently formatted.
| </section> | ||
|
|
||
| <article class="side-card"> | ||
| <img src="https://images.surferseo.art/5f496a4a-799c-4502-8e9e-2f396dae9c91.png" alt=""> |
Contributor
There was a problem hiding this comment.
Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images fail to load, giving users essential context about the content or function of the image.
Can you give a more descriptive alt value to the images?
Comment on lines
+23
to
+30
| Purpose of a README File | ||
|
|
||
| Provides an overview of the project | ||
| Describes installation and setup steps | ||
| Documents usage instructions | ||
| List contributors and guidelines for contributing | ||
| Contains licensing information | ||
| Enhances project visibility and usability |
Contributor
There was a problem hiding this comment.
These phrases are currently being treated as part of a single paragraph instead of as separate phrases.
This is what they look like when rendered:
| Contains licensing information | ||
| Enhances project visibility and usability | ||
| </p> | ||
| <a href="https://datamanagement.hms.harvard.edu/collect-analyze/documentation-metadata/readme-files">Read More</a> |
Contributor
There was a problem hiding this comment.
This link is not visible on the page.
| </article> | ||
|
|
||
| <article class="side-card"> | ||
| <img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZoAAAB7CAMAAAB6t7bCAAAA21BMVEX////wPC42JwEmEQArGAA0JQCSjYP6x8QzIwAhBgDvLhzvKhawrKPwNygkDgDQzMXh39kvHgC8t63zZ13vJQ4sGwAeAAAwHwD4q6YoFACHf27wNCPv7uv6wb1gVT719fJJPCD3n5r96un2mJLc2dL5urb4qKP82NbxSz9WSzaqpZsYAADvIgbxRjhPQyv7z8xvaF07LAAAAAD+8/L84uHyVUtpYE6blYqDfXP5s64QAABVSS3Gw7p2bl30fXZFNxw+MBH0cWf1jojyXVNhV0TzbmZmXlBAMQ+AeGn+LBJeAAAHMklEQVR4nO2ca3eaShSGkYsFjII2SBASktRL1NRqa3MlMWnTk/z/X3S4DQw4KKak65zmfT4kqyMdV3jWzOzZ7IHjAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/hjflstvVffp6LruVt3pu2Nwpqrfv1TapVufiV1zPKm00/fHQaNZqzUbHyrs0r0VZJ6XzOlVhZ2+Pw4atZAq3UwUPmLar67Td8cwNlOpmwszVmNdVtbnuyM1U6WbYzlWY2BGey0nlJkK3dyy1DhX9Xr9SqvoK/52Rue12lu4uTMYE5p3I4ridK+ab/j7GTTexM1eN1bT1dPGieA3CFBTlsH+m7i5C0M084be2FwZUFOS62Xwc/A2c9rldDq9uc0sLLwENeUYnn8+DX6vuTmspn/HyeZpvHAgQc12/Ki5ecZ0o1bkJsfYhJpShPuZxE1Dtd/aTc/ioaYMQzWUYH8P3RweHn6qUXLsyt04d5EZXuhU3fVfRmwmcRNw/wo3ekQu+e/oKY7/737njicbHWl1FKMze3zvUNkZys33ZtLa3O7G6fSOVtHtli96Kb6LusgTxDrHuTOlLSUtkhlhQQ0DOm9WU+9J80CtlXbj9B5aoilLEaZBEGX/js8NiWAFasYyv44BNescZDIA6jVpH9GhwGY33rMlMW63PyYWjj9KUhUi1OxA1kyRmo3rzZ7FutlEjWOk2iI1Jn2FHCFCTZ6cmZqdTGhfcjmbwhhaE4gZ2Wy3E0tS2xAF/44745Yo02pmhq+CXPRwHPEMNTnyZnyW5LOhmv2gKGezikeBbI3n8/m4FQ0SafbSq086QbTWr6/kVE0QsTmXcWhg7blOxJ/5e/8/MMw0PyYxWjk3e63oLpur0IPrLUIP8oqKoTstSk34n4SooYV9DRuGGX9K+zzyPwqrnUq5uY0GjZRMSXq0nRRf0ms0BWp2gmkmFvAYjp0Sbtz4rltpwj+erZR0koKa3SgwU1OD+/8zykMfbHWjxXMVtWfUoydnVH4ManaiyEyk5qMa5ToPGk1bbW5w47WSMDlhmvUANbtRaCZW04zz0KPl6Pq7XexGK1RD1WhAzQ4UmyFqavZZEqs9FrvpxxOakaqJJzSoeRVfis0kaig33z5Tn9tLuicSBrS8pCnOZ2JCexX3dqGZVE2tMSTXn1DXqz8yXUXbGF6ekX2MNl277VBTno/NQjO0mhG5/gM1ypqPma4m8V02FxPN5fTORWxGEhE8v4aSoyY5ynFIqUnTbCEuyZDJltLtKkKbj6PpdD6Dmh0otdbU7BNy/Q9K5Xnu7I1HCgAzmAsqUQM1O1AiQguI44AlZWb/JN/XpLv+UKAt0uc1oGYXtu5rwmXlZ+hmST2MXjfjj5tZzo3UGmeS/FCzE1uyAZGMZu1+MLhvbjbDcS/BAiNLwWMYSTaN7iJ3jqZQDYqdmGzMoSUhnK2qG2ezgItgI2McPc9uha50/HSl5Q/UFqqh9j6AosBNVk0GtpmnwIw8c1w3eC7GOue8poY8wJFkHItmwnazH2aeWWo2mNlc7LemhjTw7bGmO46u3eEMVBaWG/tXsPSfMD5hm4kKMeVxX9f9ccP+HmLCIGocooY3W/LDatFSem/zF/5/WXdDNpTX6pqZT6wetHhXI1vtxWr29M/8pXe5p+lUHlr3JqS+SVrVO/3wMTVdViPLkq8WM1uOvJvmGXnRxmNuSmswzXCXVhoy+9GZ2TYMS1DE2fwytuN8VdJiKElsfQ2DsuS8OsHCufU8OTd2IuCDWsYM1xN5FnJbkC/DgeBMs59E8bI7MzKtkoJYbY1htnpzQNqXmVGjFphJCmrWkZS74AK2Gk6fCelYMgX5ySv4gvdMtub5gDRnqjcLzXDcop13kqAEO0/nq5CBHOh06yuxFTQoxuppggpBJrSb5i/SeqKWMsPpzBrmaDQ8++uNO9nLMEkWFVfrBA1eH/WBhdA1TXY8o53a5cz4K3q4apimH2jli9K72K38LutulmfNkmZeooPnF0fHD7xsGpZlGGLyThq8Zuu3ybyb5uzHp5/nqZmi2CziLgwD4udmjt7XvH5fI+8LQoqsAjLrjW3TlWcbzbg30aKS3TD2482OiD1+BbAyMwHsHEBCP0wG5N/Y5MRq8JKtShiyc53MvFlKlB0zn7KtnoAwoEpYbraZIYlLITM8nPgFaPICYXE1rLvZaoZzbuJV5bnX0foBmveixDsdC0tNVeTdbDfDcUdxMkAyBDE69SyQ7Jj5jEFTGdlcZxkznN6iT83SmAZWmgqh3ZQy48doDwLrZLqszJDmr5TUTUkz/tbmklfENp1Ik9tidzXBs7GKIW5Km/FxvPp81u52lZbQUpSuMZvX14pqwO8Tvh19JzMhruP0vc6k43l9ZlENqIDr2v6+Pdx+HfjznI5Gp9uvAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA+G/zL/GAnCl2sO8VAAAAAElFTkSuQmCC" alt="Example of a website wireframe"> |
Contributor
There was a problem hiding this comment.
Embedding data URL image in HTML can reduce the readability of HTML. It's better to keep the image in a separate file.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Page made according to specification. However, I was not able to remove the trailing slash on HTML tags ( /> ) as I couldn't configure prettier to stop adding them.
Questions
Before I forgot how to open a new branch, I have saved all my previous commit in the main branch, How can I move these commits to the newest branch that I created.